feat: improve error handling and parser #224

SofianD · 2024-01-26T15:35:17Z

No description provided.

test/utils.spec.ts

src/request.ts

src/class/undiciResponseHandler.ts

src/common/errors.ts

src/request.ts

Dafyh · 2024-02-07T13:17:51Z

src/request.ts

+  if (options.mode === "parse" || !options.mode) {
+    data = await responseHandler.getData<T>("parse");
+  }
+  else if (options.mode === "decompress") {
+    data = await responseHandler.getData("decompress");
+  }
+  else {
+    data = await responseHandler.getData("raw");
+  }


Suggested change

if (options.mode === "parse" || !options.mode) {

data = await responseHandler.getData<T>("parse");

}

else if (options.mode === "decompress") {

data = await responseHandler.getData("decompress");

}

else {

data = await responseHandler.getData("raw");

}

if (options.mode === "parse" || !options.mode) {

data = await responseHandler.getData<T>("parse");

}

else {

data = await responseHandler.getData(options.mode);

}

fraxken

I think you need to update the README to includes new docs like errors no?

fraxken · 2024-02-07T13:44:21Z

test/undiciResponseHandler.spec.ts

+// Import Third-party Dependencies
+import { brotliCompressSync, deflateSync, gzipSync } from "zlib";


zlib is a Node dependency

test/undiciResponseHandler.spec.ts

fraxken · 2024-02-07T13:53:58Z

src/utils.ts

@@ -83,6 +47,14 @@ export function createHeaders(options: Partial<Pick<RequestOptions, "headers" |
  return headers;
 }

+export function isHttpieError(error) {


Suggested change

export function isHttpieError(error) {

export function isHttpieError(error: unknown): error is HttpieError {

fraxken · 2024-02-07T13:54:20Z

src/utils.ts

+  return error instanceof HttpieError;
+}
+
+export function isHTTPError(error) {


Suggested change

export function isHTTPError(error) {

export function isHTTPError(error: unknown): error is HttpieOnHttpError {

fraxken · 2024-02-07T13:58:19Z

test/HttpieOnHttpError.spec.ts

+// Import Internal Dependencies
+import { HttpieOnHttpError } from "../src/class/HttpieOnHttpError";
+
+describe("HttpieOnHttpError", () => {
+  it("it should create an HttpieOnHttpError with the properties of RequestResponse", () => {
+    const reqResponse = {
+      statusCode: 404,
+      statusMessage: "Not Found",
+      data: null,
+      headers: {}
+    };
+
+    const error = new HttpieOnHttpError(reqResponse);
+    expect(error.name).toStrictEqual("HttpieOnHttpError");
+    expect(error).toMatchObject(reqResponse);
+  });
+});


This test do not provide any value (not testing anything).

PierreDemailly approved these changes Jan 26, 2024

View reviewed changes

SofianD force-pushed the fix-parseUndiciResponse branch from ba70dc2 to 37d7cc5 Compare January 26, 2024 15:42

Dafyh reviewed Jan 26, 2024

View reviewed changes

test/utils.spec.ts Outdated Show resolved Hide resolved

Dafyh approved these changes Jan 26, 2024

View reviewed changes

SofianD self-assigned this Jan 26, 2024

SofianD marked this pull request as draft January 26, 2024 16:03

Dafyh reviewed Jan 30, 2024

View reviewed changes

test/utils.spec.ts Outdated Show resolved Hide resolved

fraxken reviewed Jan 30, 2024

View reviewed changes

src/request.ts Outdated Show resolved Hide resolved

SofianD force-pushed the fix-parseUndiciResponse branch 2 times, most recently from 4e4d3cf to 0bc42c9 Compare February 5, 2024 13:57

SofianD marked this pull request as ready for review February 5, 2024 13:59

SofianD force-pushed the fix-parseUndiciResponse branch 2 times, most recently from 9d8cc24 to 3791587 Compare February 5, 2024 14:38

SofianD changed the title ~~fix(utils.ts): parseUndiciResponse handles application/pdf header, it now returns the buffer without converting it to a string~~ feat: improve error handling and parser Feb 5, 2024