Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Drop redundant PHPStan configuration options #781

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[TASK] Drop redundant PHPStan configuration options #781

merged 1 commit into from
Dec 19, 2024

Conversation

oliverklee
Copy link
Contributor

scanDirectories is not needed when paths is set.

@oliverklee
[TASK] Drop redundant PHPStan configuration options
e6e80ac 
`scanDirectories` is not needed when `paths` is set.
@oliverklee oliverklee self-assigned this Dec 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 38.583%. remained the same
when pulling e6e80ac on cleanup/phpstan-config
into 1c1cdda on main.

JakeQZ
JakeQZ approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this was not present in the config for Emogrifier.

@JakeQZ JakeQZ merged commit fe2eaa0 into main Dec 19, 2024
22 checks passed
@JakeQZ JakeQZ deleted the cleanup/phpstan-config branch December 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ