Handle scientific notation when parsing sizes #179
Conversation
I’m not exactly sure what you mean. Size is exactly designed to handle numbers… But I agree that we should probably store additional metadata about how the size was formatted originally and provide ways for |
lib/Sabberworm/CSS/Value/Size.php
Outdated
| @@ -28,9 +28,11 @@ public static function parse(ParserState $oParserState, $bIsColorComponent = fal | |||
| if ($oParserState->comes('-')) { | |||
| $sSize .= $oParserState->consume('-'); | |||
| } | |||
| while (is_numeric($oParserState->peek()) || $oParserState->comes('.')) { | |||
| while (is_numeric($oParserState->peek()) || $oParserState->comes('.') || $oParserState->comes('e+', true) || $oParserState->comes('e-', true)) { | |||
There was a problem hiding this comment.
If I’m not mistaken, the + isn’t mandatory.
|
I was thinking of a |
|
Issues
======
- Added 3
Complexity increasing per file
==============================
- lib/Sabberworm/CSS/Value/Size.php 2
See the complete overview on Codacy |
| background-color: rgba(62,174,151,3.0418206565232E+21); | ||
| z-index: 3.0418206565232E-2; | ||
| font-size: 1em; | ||
| top: 1.923478e2px; |
There was a problem hiding this comment.
| @@ -0,0 +1,6 @@ | |||
| body { | |||
| background-color: rgba(62,174,151,3.0418206565232E+21); | |||
There was a problem hiding this comment.
| @@ -0,0 +1,6 @@ | |||
| body { | |||
| background-color: rgba(62,174,151,3.0418206565232E+21); | |||
| z-index: 3.0418206565232E-2; | |||
There was a problem hiding this comment.
Parsing numbers written in scientific notation raises
UnexpectedTokenException. This PR fixes this.It might be a good idea to separate the number parsing and rendering from the
Sizeclass, however this will break backwards compatibility, so it might have to wait for a new major version release. Otherwise the numbers will have to extendSize...