Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix total nft issue #1550

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Fix total nft issue #1550

merged 5 commits into from
Oct 23, 2019

Conversation

gesseekur
Copy link
Contributor

@gesseekur gesseekur commented Oct 22, 2019 •
edited
Loading

Bug

@gesseekur gesseekur added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #1550 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1550      +/-   ##
===========================================
- Coverage    19.33%   19.32%   -0.01%     
===========================================
  Files          323      323              
  Lines         9135     9139       +4     
  Branches      1672     1672              
===========================================
  Hits          1766     1766              
- Misses        6861     6865       +4     
  Partials       508      508
Impacted Files Coverage Δ
...agerContainer/components/NftDetails/NftDetails.vue 0% <0%> (ø) ⬆️
...ainers/NFTManagerContainer/NFTManagerContainer.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4685793...0f108be. Read the comment docs.

@gamalielhere gamalielhere merged commit 4a7408b into develop Oct 23, 2019
@gamalielhere gamalielhere deleted the bug/nft_manager branch October 23, 2019 01:40
This was referenced Jul 31, 2022
Open
Closed
@0racl3z 0racl3z mentioned this pull request Aug 1, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 3, 2022
Closed
@Manny27nyc Manny27nyc mentioned this pull request Jun 10, 2023
Closed
@Manny27nyc Manny27nyc mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamalielhere gamalielhere gamalielhere approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

@SteveMieskoski SteveMieskoski Awaiting requested review from SteveMieskoski

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gesseekur @kvhnuke @gamalielhere @mew-bot