Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix issue with selecting empty accounts when HW scanning #4184

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

FrederikBolding
Copy link
Collaborator

No description provided.

@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #4184 (67a4fd3) into master (765a8b9) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4184      +/-   ##
==========================================
+ Coverage   77.98%   78.10%   +0.11%     
==========================================
  Files         569      569              
  Lines       12334    12338       +4     
  Branches     3266     3268       +2     
==========================================
+ Hits         9619     9636      +17     
+ Misses       2681     2668      -13     
  Partials       34       34              
Impacted Files Coverage Δ
src/features/AddAccount/components/HDWList.tsx 88.13% <100.00%> (+9.56%) ⬆️
src/features/AddAccount/components/HDWTable.tsx 90.00% <100.00%> (+6.32%) ⬆️
src/features/SwapAssets/stateFormFactory.tsx 69.79% <0.00%> (+4.16%) ⬆️
src/features/AddAccount/components/helpers.ts 100.00% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765a8b9...67a4fd3. Read the comment docs.

@FrederikBolding FrederikBolding merged commit f8f0687 into master Nov 1, 2021
@FrederikBolding FrederikBolding deleted the fb/hw-scanning-hotfix branch November 1, 2021 20:16
GuillaumeRx pushed a commit that referenced this pull request Feb 3, 2022
* Fix a bug with selecting empty accounts when HW scanning

* Add test
GuillaumeRx pushed a commit that referenced this pull request Feb 3, 2022
* Fix a bug with selecting empty accounts when HW scanning

* Add test
GuillaumeRx pushed a commit that referenced this pull request Feb 3, 2022
* Fix a bug with selecting empty accounts when HW scanning

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants