Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap static assets with api #3230

Merged
merged 9 commits into from
May 5, 2020
Merged

Conversation

amacar
Copy link
Contributor

@amacar amacar commented Apr 29, 2020

[ch5670]

@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@amacar amacar force-pushed the ap/swap-config-with-assets-from-api branch from f44c4f2 to d992775 Compare April 30, 2020 13:03
@amacar amacar force-pushed the ap/swap-config-with-assets-from-api branch from d992775 to acf2553 Compare May 4, 2020 11:08
@amacar amacar marked this pull request as ready for review May 4, 2020 11:16
@amacar amacar requested review from vilsbole and blurpesec May 4, 2020 11:16
common/v2/types/asset.tsx Outdated Show resolved Hide resolved
common/v2/services/Store/Asset/AssetProvider.tsx Outdated Show resolved Hide resolved
@vilsbole
Copy link
Contributor

vilsbole commented May 5, 2020

Great job! If you can just rebase, then I will merge.

@amacar amacar force-pushed the ap/swap-config-with-assets-from-api branch from 4880c96 to f53bc66 Compare May 5, 2020 13:57
@amacar
Copy link
Contributor Author

amacar commented May 5, 2020

Great job! If you can just rebase, then I will merge.

Solved conflicts, should be good now.

@blurpesec blurpesec merged commit 6957c8c into master May 5, 2020
@blurpesec blurpesec deleted the ap/swap-config-with-assets-from-api branch May 5, 2020 14:31
@sohkai
Copy link

sohkai commented May 12, 2020

Just curious on this, is the file at https://mycryptoapi.com/api/v1/assets.json stored in a git repository somewhere? I saw https://github.com/MyCryptoHQ/assets/blob/master/assets/assets.json, but this only looks like input to the final file hosted under the API.

Our use case is similar in that we used to embed a list of verified tokens in our frontend: https://github.com/aragon/aragon-apps/blob/master/apps/agent/app/src/lib/verified-tokens.js

@blurpesec
Copy link
Collaborator

blurpesec commented May 12, 2020

@sohkai
This new api basically just periodically combines two open-source repos atm. We pull the token data from https://github.com/ethereum-lists/tokens/tree/master/tokens and then we add on some of the relevant 3rd party api mappings (coingecko ids, cryptocompare ids, coincap ids) from https://github.com/MyCryptoHQ/assets/blob/master/assets/assets.json

It should also be noted that we have always only pulled from the ethereum-lists/tokens repo. We've been using this script:
parse-eth-tokens --networks all --output ./common/v2/database/data/tokens --exclude 0x5a276Aeb77bCfDAc8Ac6f31BBC7416AE1A85eEF2,0x0027449Bf0887ca3E431D263FFDeFb244D95b555,

to pull from there. parse-eth-tokens is https://github.com/MyCryptoHQ/parse-eth-tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants