Changes return from BalanceCache from IEnumerable to ICollection

My-Financial-Hub · Apr 18, 2024 · 0198082 · 0198082
1 parent 2e04190
commit 0198082
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/api/core/FinancialHub.Core.Domain/Interfaces/Caching/IBalancesCache.cs b/src/api/core/FinancialHub.Core.Domain/Interfaces/Caching/IBalancesCache.cs
@@ -6,7 +6,7 @@ public interface IBalancesCache
     {
         Task AddAsync(BalanceModel balance);
         Task AddAsync(IEnumerable<BalanceModel> balances);
-        Task<IEnumerable<BalanceModel>> GetByAccountAsync(Guid accountId);
+        Task<ICollection<BalanceModel>> GetByAccountAsync(Guid accountId);
         Task<BalanceModel?> GetAsync(Guid id);
         Task RemoveAsync(Guid id);
     }

diff --git a/src/api/core/FinancialHub.Core.Infra.Caching/Repositories/BalancesCache.cs b/src/api/core/FinancialHub.Core.Infra.Caching/Repositories/BalancesCache.cs
@@ -95,7 +95,7 @@ await this.cache.SetAsync(
             }
         }
 
-        public async Task<IEnumerable<BalanceModel>?> GetByAccountAsync(Guid accountId)
+        public async Task<ICollection<BalanceModel>?> GetByAccountAsync(Guid accountId)
         {
             var prefix = $"{ACCOUNT_PREFIX}:{accountId}:balances";
             var result = await this.cache.GetAsync(prefix);
@@ -106,7 +106,7 @@ await this.cache.SetAsync(
             }
 
             this.logger.LogInformation("Balances from account {id} found in cache", accountId);
-            return result.FromByteArray<BalanceModel[]>() ?? null;
+            return result.FromByteArray<BalanceModel[]>() ?? Array.Empty<BalanceModel>();
         }
 
         public async Task RemoveAsync(Guid id)

diff --git a/src/api/core/FinancialHub.Core.Infra/Providers/BalancesProvider.cs b/src/api/core/FinancialHub.Core.Infra/Providers/BalancesProvider.cs
@@ -68,8 +68,8 @@ public async Task<int> DeleteAsync(Guid id)
         public async Task<ICollection<BalanceModel>> GetAllByAccountAsync(Guid accountId)
         {
             var balances = await this.cache.GetByAccountAsync(accountId);
-            if(balances == null)
-                return Array.Empty<BalanceModel>();
+            if(balances != null)
+                return balances;
 
             var entities = await this.repository.GetAsync(x => x.AccountId == accountId);