Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Channel Backups #607

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Static Channel Backups #607

merged 4 commits into from
Jun 27, 2023

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Jun 20, 2023

Part of #237

Initial implementation of static channel backups, stores the channel monitors and when you attempt to recover it'll send a dummy channel re-establish event to tell the counter party to force close the channel.

Things still todo in follow ups:

  • save to server
  • automate backups
  • encrypt backups
  • automate recovery flow

@benthecarman benthecarman requested a review from TonyGiorgio June 20, 2023 23:42
@benthecarman benthecarman force-pushed the scb branch 3 times, most recently from 483747e to 7b01cca Compare June 21, 2023 19:28
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing and need to test but here's a few initial things

mutiny-core/src/node.rs Outdated Show resolved Hide resolved
mutiny-core/src/node.rs Show resolved Hide resolved
mutiny-core/src/node.rs Show resolved Hide resolved
mutiny-core/src/nodemanager.rs Outdated Show resolved Hide resolved
mutiny-core/src/nodemanager.rs Outdated Show resolved Hide resolved
@TonyGiorgio
Copy link
Contributor

Do you think this is something we can use? I really like this idea: ElementsProject/lightning#5361

@benthecarman
Copy link
Collaborator Author

Do you think this is something we can use? I really like this idea: ElementsProject/lightning#5361

Made an issue, would be cool to do eventually, probably easier to ignore for now

@benthecarman benthecarman force-pushed the scb branch 2 times, most recently from 7223298 to c60c94f Compare June 23, 2023 21:57
mutiny-core/src/nodemanager.rs Show resolved Hide resolved
mutiny-core/src/scb/message_handler.rs Outdated Show resolved Hide resolved
mutiny-core/src/scb/mod.rs Show resolved Hide resolved
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks solid. Will come down to more testing I think but I think we can go ahead and merge and get this in the settings and emergency page.

@benthecarman benthecarman merged commit 17c793d into master Jun 27, 2023
@benthecarman benthecarman deleted the scb branch June 27, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants