Do not let files steal focus from commit list #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exactly-one-kas
approved these changes
Dec 22, 2022
|
yes looks fine to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #382
The issues seems to be solved by deleting
setFocus()inDoubleTreeWidget::filesSelected().I don't see any reason to set the focus explicitly: The tree view should get focus when selecting a file -- this is done by clicking the view; hence, it automatically gets focus. But there is no reason the view gets focus accidentally when changing the file selection by selecting a commit from commit list; focus should stay in commit list.