Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option for /mv confirm timeout #3169

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Add config option for /mv confirm timeout #3169

merged 2 commits into from
Feb 13, 2025

Conversation

zax71
Copy link
Member

@zax71 zax71 commented Feb 12, 2025 •
edited by github-actions bot
Loading

This is a draft, I've got no clue how to get the dependency injection working to get MVCoreConfig in to CommandQueuePayload

📦 Artifacts generated:

@zax71 zax71 changed the title Got the config done but DI is hard Add config option for /mv confirm timeout Feb 12, 2025
@benwoo1110 benwoo1110 marked this pull request as ready for review February 13, 2025 05:35
@benwoo1110 benwoo1110 merged commit 9956142 into MV5 Feb 13, 2025
4 checks passed
@benwoo1110 benwoo1110 deleted the zax71/MV5/confirm-command-custom-timeout branch February 13, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwoo1110 benwoo1110 benwoo1110 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zax71 @benwoo1110