unexpected CHALLENGE after REJECT behavior was fixed (#44)

MultifactorLab · Apr 24, 2024 · 24d3d79 · 24d3d79
1 parent 12458d4
commit 24d3d79
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/MultiFactor.Radius.Adapter/Server/RadiusRouter.cs b/MultiFactor.Radius.Adapter/Server/RadiusRouter.cs
@@ -222,14 +222,21 @@ public async Task HandleRequest(PendingRequest request)
                         CreateAndSendRadiusResponse(request);
                         return;
                     }
-                    
-                    if (code == PacketCode.AccessAccept) 
+
+                    if (code != PacketCode.AccessAccept)
                     {
-                        request.AuthenticationState.SetSecondFactor(AuthenticationCode.Accept);
+                        _logger.Information("Second factor rejected for user '{user:l}' from {host:l}:{port}",
+                            request.UserName, request.RemoteEndpoint.Address, request.RemoteEndpoint.Port);
+                        request.AuthenticationState.SetSecondFactor(AuthenticationCode.Reject);
                         request.ResponseCode = request.AuthenticationState.GetResultPacketCode();
                         CreateAndSendRadiusResponse(request);
                         return;
-                    } 
+                    }
+
+                    request.AuthenticationState.SetSecondFactor(AuthenticationCode.Accept);
+                    request.ResponseCode = request.AuthenticationState.GetResultPacketCode();
+                    CreateAndSendRadiusResponse(request);
+                    return;     
                 }
 
                 request.ResponseCode = request.AuthenticationState.GetResultPacketCode();