Skip to content

Commit

Permalink
fix!: drop support for Node 4, 6, 8, 10 (protobufjs#1764)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-fenster authored Jul 7, 2022
1 parent 8aad1dd commit 50370dd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node_version: ["4", "4.3.2", "6", "8", "10", "12"]
node_version: ["12", "14", "16", "18"]
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node_version }}
- name: 'Install the latest @types/node that works'
if: ${{ matrix.node_version == '4' || matrix.node_version == '4.3.2' || matrix.node_version == '6' }}
run: npm install --save --save-exact @types/node@17.0.41
- name: "Install dependencies"
run: npm install
- name: "Test sources"
Expand Down
3 changes: 3 additions & 0 deletions cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"type": "git",
"url": "https://github.com/protobufjs/protobuf.js.git"
},
"engines": {
"node": ">=12.0.0"
},
"license": "BSD-3-Clause",
"main": "index.js",
"types": "index.d.ts",
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"repository": "protobufjs/protobuf.js",
"bugs": "https://github.com/protobufjs/protobuf.js/issues",
"homepage": "https://protobufjs.github.io/protobuf.js/",
"engines": {
"node": ">=12.0.0"
},
"keywords": [
"protobuf",
"protocol-buffers",
Expand Down

0 comments on commit 50370dd

Please sign in to comment.