Skip to content

Commit

Permalink
fix: remove unused @types/long (protobufjs#1785)
Browse files Browse the repository at this point in the history
* fix: remove unused `@types/long`

* fix: typescript tests

Co-authored-by: Alexander Fenster <fenster@google.com>
  • Loading branch information
SimenB and alexander-fenster authored Aug 17, 2022
1 parent bb6b1d4 commit 0f4af83
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 24 deletions.
11 changes: 0 additions & 11 deletions cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"prof": "node bench/prof",
"test": "npm run test:sources && npm run test:types",
"test:sources": "tape -r ./lib/tape-adapter tests/*.js tests/node/*.js",
"test:types": "tsc tests/comp_typescript.ts --lib es2015 --strictNullChecks --experimentalDecorators --emitDecoratorMetadata && tsc tests/data/test.js.ts --lib es2015 --noEmit --strictNullChecks && tsc tests/data/*.ts --lib es2015 --noEmit --strictNullChecks",
"test:types": "tsc tests/comp_typescript.ts --lib es2015 --esModuleInterop --strictNullChecks --experimentalDecorators --emitDecoratorMetadata && tsc tests/data/test.js.ts --lib es2015 --esModuleInterop --noEmit --strictNullChecks && tsc tests/data/*.ts --lib es2015 --esModuleInterop --noEmit --strictNullChecks",
"make": "npm run lint:sources && npm run build && npm run lint:types && node ./scripts/gentests.js && npm test"
},
"dependencies": {
Expand All @@ -50,7 +50,6 @@
"@protobufjs/path": "^1.1.2",
"@protobufjs/pool": "^1.1.0",
"@protobufjs/utf8": "^1.1.0",
"@types/long": "^4.0.1",
"@types/node": ">=13.7.0",
"long": "^5.0.0"
},
Expand Down
2 changes: 2 additions & 0 deletions tests/data/convert.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import * as $protobuf from "../..";
import Long from "long";

export interface IMessage {
stringVal?: (string|null);
stringRepeated?: (string[]|null);
Expand Down
2 changes: 2 additions & 0 deletions tests/data/test.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import * as $protobuf from "../..";
import Long from "long";

export namespace jspb {

namespace test {
Expand Down

0 comments on commit 0f4af83

Please sign in to comment.