Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Loop stays open when Caps Lock is enabled #35

Closed
walnut-the-hacker opened this issue Sep 16, 2023 · 2 comments · Fixed by #36
Closed

🐛 Loop stays open when Caps Lock is enabled #35

walnut-the-hacker opened this issue Sep 16, 2023 · 2 comments · Fixed by #36
Assignees
@MrKai77
Labels
Bug

Comments

@walnut-the-hacker
Copy link

Bug Description

Loop stays open when Caps Lock is enabled.

Steps To Reproduce

  1. Enable Caps Lock
  2. Open Loop with trigger key
  3. Select direction and release trigger key

Expected Behavior

Loop should close when the trigger key is released

Actual Behavior

Loop stays open

Screenshots

No response

MacOS Version

Sonoma 14.0 Beta

Loop version

Version 1.0.0-beta.9 (337)

Additional Context

No response
@MrKai77
Copy link
Owner

MrKai77 commented Sep 16, 2023 •
edited
Loading

Thanks for reporting this bug! I can reproduce this as well. It seems like having Caps Lock enabled changes the NSEvent.modifierFlags.rawValue from 256 to something else on the keyUp event, so Loop can't detect when the key is released.

@MrKai77 MrKai77 self-assigned this Sep 16, 2023
MrKai77 added a commit that referenced this issue Sep 16, 2023
@MrKai77
🐛 #35 Don't activate Loop when Caps Lock key is enabled
f013d99
@MrKai77
Copy link
Owner

MrKai77 commented Sep 16, 2023

I fixed it! It seems like this bug also affected the new Keycorder introduced in #31, so I fixed that as well!

@MrKai77 MrKai77 linked a pull request Sep 16, 2023 that will close this issue
🐛 #35 Don't activate Loop when Caps Lock key is enabled #36
Merged
MrKai77 added a commit that referenced this issue Sep 16, 2023
@MrKai77
🐛 #35 Don't activate Loop when Caps Lock key is enabled
ed40079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrKai77 MrKai77

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 #35 Don't activate Loop when Caps Lock key is enabled MrKai77/Loop
2 participants
@MrKai77 @walnut-the-hacker