Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Instant animation is not instant #299

Closed
2 tasks done
YonglinChann opened this issue Mar 30, 2024 · 3 comments · Fixed by #300
Closed
2 tasks done

🐛 Instant animation is not instant #299

YonglinChann opened this issue Mar 30, 2024 · 3 comments · Fixed by #300
Assignees
Labels

Comments

@YonglinChann
Copy link

Bug Description

Hello! I noticed that in the past Beta 14, when I set the speed of the animation to Instant, the animation preview will be canceled and only Preview will be provided, which is a simple effect. However, in the latest Beta 15, no matter how the dynamic level is set, the effect of Instant is almost the same as Fast, and the animation is forced to be provided. However, on the MacBook Pro with ProMotion refresh rate, the animations of Loop do not fit the 120Hz display, and these animations are very stuck on the ProMotion screen.

Steps To Reproduce

When set to Instant, animation will be forced to appear every time it is used.

Expected Behavior

It is hoped that Loop can restore the ability to provide only previews and cancel the mandatory dynamic effect when the animation is set to Instant.
Or Loop's animation can be perfectly adapted to MacBook Pro with ProMotion 120Hz refresh rate.

Actual Behavior

It is hoped that Loop can restore the ability to provide only previews and cancel the mandatory dynamic effect when the animation is set to Instant.
Or Loop's animation can be perfectly adapted to MacBook Pro with ProMotion 120Hz refresh rate.

Screenshots

No response

MacOS Version

macOS Sonoma 14.4.1 (23E224)

Loop Version

Version 1.0.0-beta.15 (817)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented Mar 30, 2024

Got it! I remade the preview window in the latest version, and it seems like I may have forgotten to remove the animation from instant. I will restore the original functionality from beta 14!

@MrKai77 MrKai77 self-assigned this Mar 30, 2024
MrKai77 added a commit that referenced this issue Mar 30, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Mar 30, 2024

Try this: Loop.zip

@MrKai77 MrKai77 changed the title 🐛 [Animation in Beta 15 version Instant setting cannot cancel animation] 🐛 Instant animation is not instant Mar 30, 2024
@MrKai77 MrKai77 linked a pull request Mar 30, 2024 that will close this issue
MrKai77 added a commit that referenced this issue Mar 30, 2024
…ion-instant-setting-cannot-cancel-animation`

🐛 #299 Instant animation is not instant
@YonglinChann
Copy link
Author

Thank you very much for taking the time to answer my questions!
At the same time, I also hope that the animation of Loop can better adapt to the MacBook Pro with a ProMotion high refresh rate screen. Because in the same type of software, their animation is not well adapted to the high refresh rate. If Loop can do this, it will be a great experience! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants