Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use owned string for prototype name deserializer #50

Merged
merged 1 commit into from
Aug 28, 2023
Merged

use owned string for prototype name deserializer #50

merged 1 commit into from
Aug 28, 2023

Conversation

deltanedas
Copy link

  • it immediately calls .to_owned() so why not just use String in the first place
  • with &str it giving me expected borrowed string, very bad

MrGVSV
MrGVSV approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks for the change!

(also apologies on my lateness to this PR)

@MrGVSV
Copy link
Owner

MrGVSV commented Aug 28, 2023

Checks failing are unrelated to this particular PR. Merging now!

@MrGVSV MrGVSV merged commit 7a00183 into MrGVSV:main Aug 28, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltanedas @MrGVSV