Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sapphire] Improved stability handling invalid URLs #445

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

tysmith
Copy link
Collaborator

@tysmith tysmith commented May 31, 2024

Fixes:

Traceback (most recent call last):
  File "/home/worker/grizzly-auto-run/venv/lib/python3.10/site-packages/sapphire/worker.py", line 146, in handle_request
    request = Request.parse(raw_request)
  File "/home/worker/grizzly-auto-run/venv/lib/python3.10/site-packages/sapphire/worker.py", line 51, in parse
    url = urlparse(
  File "/usr/lib/python3.10/urllib/parse.py", line 400, in urlparse
    splitresult = urlsplit(url, scheme, allow_fragments)
  File "/usr/lib/python3.10/urllib/parse.py", line 500, in urlsplit
    _checknetloc(netloc)
  File "/usr/lib/python3.10/urllib/parse.py", line 441, in _checknetloc
    raise ValueError("netloc '" + netloc + "' contains invalid " +
ValueError: netloc '⁡<<=)𤱍᩿ﷺ٠𯄬Ⱥ㮺^=𖔠𯊖𯚇^=𯓚*=𐎭᷌ 󠳀ك%𝟯ᾂ٪℀�0𧸄ູ𯨾⦆𯹕㔮𝅱‫𝬍𣥫%=𝋼&`𐇽𛒀𓪂٠𨕁゚R𯄎٪߫孁' contains invalid characters under NFKC normalization

@tysmith tysmith self-assigned this May 31, 2024
@tysmith tysmith requested a review from a team as a code owner May 31, 2024 18:09
@tysmith tysmith merged commit 20570d8 into master May 31, 2024
4 checks passed
@tysmith tysmith deleted the fix-urlparse branch May 31, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants