Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sapphire] Update tests #403

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[sapphire] Update tests #403

merged 1 commit into from
Jan 4, 2024

Conversation

tysmith
Copy link
Collaborator

@tysmith tysmith commented Dec 22, 2023

  • use urlsplit() instead of urlparse()
  • use sha1() instead of md5()
  • update imports

@tysmith
[sapphire] Update tests
b1f9ef4 
- use urlsplit() instead of urlparse()
- use sha1() instead of md5()
- update imports
@tysmith tysmith self-assigned this Dec 22, 2023
@tysmith tysmith requested a review from a team as a code owner December 22, 2023 19:41
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99abf07) 99.53% compared to head (b1f9ef4) 99.53%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          52       52           
  Lines        5534     5534           
=======================================
  Hits         5508     5508           
  Misses         26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tysmith tysmith merged commit ee4b148 into master Jan 4, 2024
4 checks passed
@tysmith tysmith deleted the sapphire-tests branch January 4, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwartzentruber jschwartzentruber jschwartzentruber approved these changes

Assignees

@tysmith tysmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tysmith @jschwartzentruber