Follow up TestCase work after major TestCase.load() change #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can help simplify adapter unit tests.
- other minor nits
jschwartzentruber
approved these changes
Nov 27, 2023
grizzly/common/storage.py
Outdated
| @@ -211,27 +258,14 @@ def clone(self): | |||
| result.https = self.https | |||
| # copy test data files | |||
| for entry, required in chain( | |||
There was a problem hiding this comment.
Instead of entry, required why not use (file_name, data_file), required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 99.51% 99.51% -0.01%
==========================================
Files 50 50
Lines 5408 5402 -6
==========================================
- Hits 5382 5376 -6
Misses 26 26 ☔ View full report in Codecov by Sentry. |
tysmith
force-pushed
the
testcase-dev
branch
from
fe6c0c6 to
10d283f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.