-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a first run crash when updating FxR with this patch applied.
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/Windows.java
Outdated
Show resolved
Hide resolved
93a745d
to
7ac5385
Compare
This should be ready for review. |
I agree this isn't pretty but I can't think of anything cleaner. @MortimerGoro last chance to comment before landing it. |
@bluemarvin @keianhzo would it be possible to use a URL based approach instead of adding the extra flags and enum? For example map |
That could be workable. I'm not sure how we would make it work with the GV history system though. I like the concept, it isn't clear how we would implement it. |
7ac5385
to
b06b581
Compare
@bluemarvin @MortimerGoro That a good idea, I've added support for it. It doesn't seem to mess up the history and it's a much cleaner solution for restoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner. Seems to work well too.
Fixes #1945 Restore library panels. I really don't like to have a flag to know if the user has initiated the interaction so if there is a better alternative I'd be happy to change this. Without the flag the panels would be closed during the restore when about:blank and home are loaded as we always close them when there is a navigation event.