Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU Layer Limitation in llamafile #534

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

BIGPPWONG
Copy link
Contributor

#533
In the current implementation, the line n_gpu_layers = std::min(n_gpu_layers, (int)hparams.n_layer); restricts the minimum value of n_gpu_layers. However, in the llama.cpp project, within the static void llm_load_hparams function, hparams.n_layer is derived from ml.get_key(LLM_KV_BLOCK_COUNT, hparams.n_layer);, which only accounts for layers that require key-value (KV) attention and does not include other potential layers, such as output layers.

This restriction might lead to performance issues, as observed in the token generation speed and GPU utilization.

By either commenting out this line or adjusting it to hparams.n_layer + 10, the issue can be mitigated, ensuring all necessary layers are properly offloaded to the GPU, improving overall performance.

@cjpais
Copy link
Collaborator

cjpais commented Oct 7, 2024

Following up on this, this is the same issue mentioned in DM @jart. Removing this line should be sufficient as far as I can tell

Copy link
Collaborator

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@jart jart merged commit 01b8d49 into Mozilla-Ocho:main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants