Follow up to the offload-arch-fix: qsort and static linkage #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jart
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks for catching this. A static long[] array each holding 8 ascii characters, combined with Cosmopolitan Libc's longsort() function could have made your job easier. Perhaps we'll save it for next time :-) I'm always interested in what we can do to pump up our support for AMD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the offload-arch-fix PR. Need to add qsort in order to dedup arch names. Use static linkage for the functions added just to avoid any possible build errors.