chore(EntityPool): workaround "unchecked generics array creation" for getEntitiesWith #5052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java generic types are a mess, especially where varargs are involved. We can't use
@SafeVarargs
on interface methods because there is no way to know the implementations of the interface are safe.In this case, in practice, there are few (if any) callers that pass more than two values.
By adding methods that explicitly take one and two values, we can present an interface the compiler doesn't need to complain about at every call site.
How to Test
entityManager.getEntitiesWith(SomeComponent.class)