test(MTE)! set default NetworkMode to NONE

[keturn]

This changes MTE's default network mode from LISTEN_SERVER to NONE.

I expect this to provide in increased reliability and speed for most MTE tests, as it removes the question of whether the server port is available and the delay on network shutdown.

Those few tests that do use createClient will need to adjust by setting their NetworkMode to LISTEN_SERVER or DEDICATED_SERVER.

The other potential incompatibility is that NONE does start with a Player; LISTEN_SERVER did not. That may be a problem if the environment does not provide a place for the player to spawn.

(Currently, we do not have any way of starting without either a network server or a player.)

Related:

• test: increase assertion accuracy Terasology/BlockDetector#14 fixes the test that was using createClient.

How to test

Run integrationTest in modules. Note only modules that import MTE from engine.integrationtest will be affected; check for module pull requests linked to #5010.

[skaldarnar]

I'm a bit afraid that the info when to set the network mode gets bit lost once this PR is merged.

Can we please add this info somewhere? Maybe in the docstring of createClient (if that's the only reason why you'll need a network-enabled mode)?

Terasology/engine-tests/src/main/java/org/terasology/engine/integrationenvironment/ModuleTestingEnvironment.java

Lines 74 to 79 in be0f9de

	/**
	* Creates a new client and connects it to the host
	*
	* @return the created client's context object
	*/
	Context createClient() throws IOException;

Or should we expand the Testing Modules section in the engine's wiki?

Other than that, this looks good to merge to me.

[keturn]

Added a note to the createClient docstring. Good suggestion, thanks!