Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InjectionHelper): inject() returns the object for chaining #5028

Merged
merged 3 commits into from
Jun 4, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented May 29, 2022

Allows doing things like

Foo x = inject(new Foo(), context);

compared to previously, when inject() was void:

Foo x = new Foo();
inject(x, context);

Won't break any existing code.

Also includes some minor changes to ContextImpl error messages.

@keturn keturn added Type: Improvement Request for or addition/enhancement of a feature Size: S Small effort likely only affecting a single area and requiring little to no research labels May 29, 2022
@keturn
Copy link
Member Author

keturn commented May 30, 2022

This isn't as necessary with #5033 deciding to use createWithConstructorInjection instead of inject.

But it's still a pretty okay change and the Context error message is a nice improvement too.

@keturn keturn force-pushed the feat/injectReturnValue branch from 35dca80 to db6ec00 Compare June 1, 2022 00:26
@skaldarnar skaldarnar merged commit 0a9b89f into develop Jun 4, 2022
@skaldarnar skaldarnar deleted the feat/injectReturnValue branch June 4, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants