fix(Context)!: correct signature of Context.get #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T get(Class<? extends T> type) would mean that `type` could be a subclass of the return value. e.g. returning a Number when asked for a Float. That's the opposite of what we wanted!
keturn
added
the
Size: S
Object is automatically the lower bound of `?`
3 tasks
skaldarnar
approved these changes
May 22, 2022
jdrueckert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T get(Class<? extends T> type) would mean that
typecould be a subclass of the return value.e.g. returning a Number when asked for a Float.
That's the opposite of what we wanted!
Might break binary compatibility and trigger a lot of recompiling. I don't expect it to break source compatibility with any current code.
Also:
feat(Context): add non-null and Optional get methods