-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated method in Block #4965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
Request for or implementation of maintenance changes
label
Nov 27, 2021
pollend
force-pushed
the
chore/remove-deprecated-method-Block
branch
from
November 27, 2021 19:52
79c0bbb
to
d9290ec
Compare
pollend
added a commit
to Terasology/Books
that referenced
this pull request
Nov 27, 2021
pollend
added a commit
to Terasology/Journal
that referenced
this pull request
Nov 27, 2021
pollend
added a commit
to Terasology/Kallisti
that referenced
this pull request
Nov 27, 2021
pollend
added a commit
to Terasology/WorkstationCrafting
that referenced
this pull request
Nov 27, 2021
pollend
added a commit
to Terasology/WorldlyTooltip
that referenced
this pull request
Nov 27, 2021
This was referenced Nov 27, 2021
nitpick: suggest to fix javadoc for |
DarkWeird
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few more instance of Tessellator this removes the usage of getMesh() for block. The standalone mesh can pulled from the meshGenerator. There is a strict precondition for meshGenerator that prevents it from every being null so the null condition can't happen.