partial port of kinematicCharacterMover #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
changed the title
pollend
changed the title
kBlaszczyk
reviewed
Apr 22, 2020
engine/src/main/java/org/terasology/logic/characters/KinematicCharacterMover.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/logic/characters/CharacterMovementSystemUtility.java
Outdated
Show resolved
Hide resolved
…MovementSystemUtility.java Co-Authored-By: Kevin Blaszczyk <kevin.blaszczyk@gmail.com>
…CharacterMover.java Co-Authored-By: Kevin Blaszczyk <kevin.blaszczyk@gmail.com>
kBlaszczyk
approved these changes
Apr 22, 2020
…ematic-character-mover
…ollend/Terasology into feature/joml-kinematic-character-mover
kBlaszczyk
approved these changes
May 8, 2020
|
I tested this with a couple modules, Default Standard, Light and Shadow. the movement seems unaffected so I think this should be ok to merge. @4Denthusiast If there isn't any rejection I'll probably merge this later today. |
Cervator
added
the
Topic: Architecture
|
Did some more testing with multiplayer and a physics / movement focus. Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a partial port of the KinematicCharacterMover. Player character should still move the same way without the changes in this file. I'll probably go through and tweaks some of the uses of Quat4f and replace them with their JOML alternatives. The kinematic character mover is an internal class to the engine so there is close to no impact on module space unless I start updated events that are emitted from the character mover.