-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): publish artifacts to Terasology artifactory #20
Conversation
build/natives/*/*.dll | ||
build/natives/*/*.dylib | ||
build-macos-amd64: | ||
runs-on: macos-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this also work with mac OS 14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos-12
is the standard for macos-latest
for GitHub-hosted runners and translates to an amd64
Intel-based Mac.
macos-14
is currently a beta runner and translates to an M1 CPU (Apple Silicion).
Thus, the workflow is using "the latest macOS runner" (macos-12
) and a "beta runner for M1" (macos-14
).
I gave it a test on my M1 Mac, and it looks like ./gradlew buildNatives
is able to build both targets for Apple Silicon (aarch64) and older Intel-based Macs (amd64) on the same machine. So maybe we can use just macos-14
here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth at least a try.
otherwise, maybe add a code comment with the explanation you just shared
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
build/natives/*/*.dll | ||
build/natives/*/*.dylib | ||
build-macos-amd64: | ||
runs-on: macos-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth at least a try.
otherwise, maybe add a code comment with the explanation you just shared
After some experimentation on my fork I finally got a successful workflow run that published artifacts for 1.0.4-SNAPSHOT, including the zipped native libraries for Windows, Mac, and Linux.
I've already added the respective Secrets to the repository.
Contributes to MovingBlocks/Terasology#5055.