Bilibili调度新增回避策略 #573
Merged
Bilibili调度新增回避策略 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nonebot-bison ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
+ Coverage 85.01% 85.39% +0.38%
==========================================
Files 88 90 +2
Lines 4491 4718 +227
==========================================
+ Hits 3818 4029 +211
- Misses 673 689 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AzideCupric
force-pushed
the
fix/bilibili-slower
branch
4 times, most recently
from
f3bfa96 to
822622d
Compare
felinae98
reviewed
Jun 22, 2024
|
设想的状态转换图 stateDiagram-v2
direction LR
[*] --> NORMAL
NORMAL --> NORMAL: 请求成功
NORMAL --> REFRESH: 请求失败
REFRESH --> NORMAL: 请求成功
REFRESH --> REFRESH: 请求失败
REFRESH --> BACKOFF: 请求失败 若重试满但回避未满
REFRESH --> RAISE: 请求失败 若重试满且回避满
BACKOFF --> BACKOFF: 回避中
BACKOFF --> REFRESH: 回避中 若已超时
RAISE --> RAISE: 请求失败
RAISE --> NORMAL: 请求成功
修改记录： |
AzideCupric
force-pushed
the
fix/bilibili-slower
branch
3 times, most recently
from
bef83cb to
ba3df50
Compare
|
用生成器正经搓了个小状态机，感觉这样看起来更清晰一点 |
felinae98
reviewed
Jul 2, 2024
felinae98
reviewed
Jul 4, 2024
| return waited < should_wait | ||
|
|
||
|
|
||
| B = TypeVar("B", bound="Bilibili") |
There was a problem hiding this comment.
不这样写的话retry_for_352的类型得全用引号包起来（
AzideCupric
force-pushed
the
fix/bilibili-slower
branch
from
a879824 to
d5bd87f
Compare
felinae98
reviewed
Jul 29, 2024
|
|
||
|
|
||
| class RetryState(StrEnum): | ||
| NROMAL = "normal" |
| self.graph = graph | ||
| self.current_state = graph["initial"] | ||
| self.machine = self.core() | ||
| self.ctx = ctx |
| self.machine = self.core() | ||
| self.ctx = ctx | ||
|
|
||
| async def core(self) -> AsyncGenerator[ActionReturn, TEvent]: |
There was a problem hiding this comment.
Suggested change
| async def core(self) -> AsyncGenerator[ActionReturn, TEvent]: | |
| async def _core(self) -> AsyncGenerator[ActionReturn, TEvent]: |
| await fsm.emit(RetryEvent.REACH_MAX_REFRESH) | ||
| case RetryActionReturn.BACKOFF_MAX: | ||
| logger.error("指数回避次数达到上限，放弃回避") | ||
| await fsm.emit(RetryEvent.REACH_MAX_BACKOFF) |
There was a problem hiding this comment.
这个地方太奇怪了，要根据 fsm 返回的结果 emit 特定事件，你这个自动机改叫手动机好了
felinae98
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原先的30s对叔叔而言还是太敏感了