Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget option "filter_reset" for dynamically added elements #327

Merged
merged 1 commit into from
Oct 10, 2013
Merged

Widget option "filter_reset" for dynamically added elements #327

merged 1 commit into from
Oct 10, 2013

Conversation

riker09
Copy link
Contributor

@riker09 riker09 commented Jun 5, 2013

The widget option "filter_reset" only works for elements that are present in the DOM on initialization of the table. Now it works for elements that have been added to the DOM at some later point as well.

The widget option "filter_reset" only works for elements that are present in the DOM on initialization of the table. Now it works for elements that have been added to the DOM at some later point as well.
@riker09
Copy link
Contributor Author

riker09 commented Jun 5, 2013

Sorry, I just noticed my editor (Geany) throw out some extra spaces at the end of some line. The good parts are in the lines 704 and 705.

@Mottie
Copy link
Owner

Mottie commented Oct 9, 2013

Hi @riker09!

Sorry, for taking so long to respond.

My only problem with this change is that it is using on() which only works in jQuery 1.7+. And as of right now, the filter widget is made to support jQuery 1.4.3+. So, if you change it to delegate() I'll include it in the next update. Or I can just make the change on my end without the merge ;)

Don't worry, I'm still working on tablesorter v3 and I only plan on supporting jQuery v1.7+ (for now).

Mottie added a commit that referenced this pull request Oct 10, 2013
Widget option "filter_reset" for dynamically added elements
@Mottie Mottie merged commit b561ff4 into Mottie:master Oct 10, 2013
Mottie added a commit that referenced this pull request Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants