Sequence node: bSavePinExecutionState is now True by default

This addressed a common issue with handling SaveGame for a directed graph.
MothCocoon · Sep 1, 2023 · 6d00a2d · 6d00a2d
1 parent 98d8fdc
commit 6d00a2d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/Source/Flow/Private/Nodes/Route/FlowNode_ExecutionSequence.cpp b/Source/Flow/Private/Nodes/Route/FlowNode_ExecutionSequence.cpp
@@ -4,6 +4,7 @@
 
 UFlowNode_ExecutionSequence::UFlowNode_ExecutionSequence(const FObjectInitializer& ObjectInitializer)
 	: Super(ObjectInitializer)
+	, bSavePinExecutionState(true)
 {
 #if WITH_EDITOR
 	Category = TEXT("Route");
@@ -16,12 +17,12 @@ UFlowNode_ExecutionSequence::UFlowNode_ExecutionSequence(const FObjectInitialize
 
 void UFlowNode_ExecutionSequence::ExecuteInput(const FName& PinName)
 {
-	if(bSavePinExecutionState)
+	if (bSavePinExecutionState)
 	{
 		ExecuteNewConnections();
 		return;
 	}
-	
+
 	for (const FFlowPin& Output : OutputPins)
 	{
 		TriggerOutput(Output.PinName, false);
@@ -33,11 +34,11 @@ void UFlowNode_ExecutionSequence::ExecuteInput(const FName& PinName)
 #if WITH_EDITOR
 FString UFlowNode_ExecutionSequence::GetNodeDescription() const
 {
-	if(bSavePinExecutionState)
+	if (bSavePinExecutionState)
 	{
 		return TEXT("Saves pin execution state");
 	}
-	
+
 	return Super::GetNodeDescription();
 }
 #endif
@@ -52,12 +53,12 @@ void UFlowNode_ExecutionSequence::ExecuteNewConnections()
 	for (const FFlowPin& Output : OutputPins)
 	{
 		const FConnectedPin& Connection = GetConnection(Output.PinName);
-		if(ExecutedConnections.Contains(Connection.NodeGuid))
+		if (!ExecutedConnections.Contains(Connection.NodeGuid))
 		{
-			continue;
+			ExecutedConnections.Emplace(Connection.NodeGuid);
+			TriggerOutput(Output.PinName, false);
 		}
-
-		TriggerOutput(Output.PinName, false);
-		ExecutedConnections.Emplace(Connection.NodeGuid);
 	}
+
+	Finish();
 }
diff --git a/Source/Flow/Public/Nodes/Route/FlowNode_ExecutionSequence.h b/Source/Flow/Public/Nodes/Route/FlowNode_ExecutionSequence.h
@@ -37,7 +37,7 @@ class FLOW_API UFlowNode_ExecutionSequence final : public UFlowNode
 	 * graph after release.
 	 */
 	UPROPERTY(EditAnywhere, Category = "Sequence")
-	bool bSavePinExecutionState = false;
+	bool bSavePinExecutionState;
 
 	UPROPERTY(SaveGame)
 	TSet<FGuid> ExecutedConnections;