Merge pull request #10 from MortenDHansen/add-cache-heater

Do not create groups from paragraphs
MortenDHansen · Mar 9, 2022 · 046a92e · 046a92e
2 parents 1de0b7f + 3244d7b
commit 046a92e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/DatabaseTranslationsTranslator.php b/src/DatabaseTranslationsTranslator.php
@@ -63,6 +63,12 @@ public function get($key, array $replace = [], $locale = null, $fallback = true)
             $group = '*';
         }
 
+        // The group should be just a word. Sometimes translation key is an entire paragraph. We put that into ungrouped
+        if (!(preg_match('/^[\pL\pM\pN_-]+$/u', $group) > 0)) {
+            $group = '*';
+            $item = $key;
+        }
+
         if (!array_key_exists($item, $this->loadedFromDb['*'][$group][$passedLocale])) {
             $this->createMissingKey($group, $item, $passedLocale);
         }

diff --git a/tests/Feature/DatabaseTranslationsTest.php b/tests/Feature/DatabaseTranslationsTest.php
@@ -354,5 +354,15 @@ public function itCreatesMissingKeysInDifferentLocales()
         $this->assertDatabaseHas('database_lang_items', ['group' => '*', 'key' => 'color', 'locale' => 'de']);
     }
 
+    /**
+     * @test
+     * @return void
+     */
+    public function itCanHandleChunksOfText()
+    {
+        __("Sometimes, translations are in fact a chunk of text. It can be very long and it makes no sense to treat it as a grouped key.");
+        $this->assertEquals('*', DatabaseLangItem::all()->first()->group);
+    }
+
 
 }