Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a failed build check if PR title doesn't match #111

Closed
exocom opened this issue Sep 14, 2020 · 3 comments
Closed

Show a failed build check if PR title doesn't match #111

exocom opened this issue Sep 14, 2020 · 3 comments
Assignees

Comments

@exocom
Copy link

exocom commented Sep 14, 2020

Hey is it possible to add a toggle to fail the build if the PR title doesn't match instead of adding a comment? IE make this configurable.

Our workflow is to look for failed builds and fix them. Currently this action always succeeds even if the branch does not match which is counter intuitive for us.

Ideally I would want to toggle them separately:

add-review: false
fail-on-error: true

@MorrisonCole
Copy link
Owner

Hey Kalarrs!

Yeah, I think that should be possible and it certainly seems to make sense - need to check the details and get back to you. It's on my TODO list for today!

@MorrisonCole MorrisonCole self-assigned this Sep 15, 2020
MorrisonCole added a commit that referenced this issue Sep 16, 2020
… regex mismatch #GH-111 (#113)

* feat: add create review/fail on regex mismatch configurations #GH-111

* wip: test configuration

* wip: test failing action

* wip: test no review

* wip: clean up

* docs: release notes
@MorrisonCole
Copy link
Owner

MorrisonCole commented Sep 16, 2020

@exocom (+@kole) I've just released v1.3.0 with new configurations for that sort of behaviour 🙏

The main README is updated with all the details, but you can now configure your workflow (for example) like:

steps:
  - uses: morrisoncole/pr-lint-action@v1.3.0
    with:
      title-regex: "#[eE][xX]-[0-9]+"
      on-failed-regex-fail-action: true
      on-failed-regex-create-review: false
      on-failed-regex-comment: "Error log for failed regex: `%regex%`!"
      repo-token: "${{ secrets.GITHUB_TOKEN }}"

If that suits you, let me know and I'll close this!

@MorrisonCole
Copy link
Owner

Gonna close this as fixed but feel free to let me know if you have any further requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants