fix: fail when user fail to send file to MSP after several retries #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undercover-cactus
force-pushed
the
fix/fail-user-remote-download
branch
from
efa5cf6 to
939cbdd
Compare
undercover-cactus
force-pushed
the
fix/fail-user-remote-download
branch
from
939cbdd to
d7ac3a1
Compare
ffarall
reviewed
Feb 13, 2025
| @@ -383,7 +383,8 @@ where | |||
| tokio::time::sleep(std::time::Duration::from_secs(1)).await; | |||
| } | |||
| Err(RequestError::RequestFailure(RequestFailure::Refused)) => { | |||
| // TODO: Handle MSP not receiving file after multiple retries. | |||
| // If MSP doesnt receive file, the burden of downloading the file will be on the MSP. | |||
There was a problem hiding this comment.
Suggested change
| // If MSP doesnt receive file, the burden of downloading the file will be on the MSP. | |
| // If MSP doesn't receive file, the burden of downloading the file will be on the MSP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the TODO comment as #361 will handle this case. The burden of downloading the file will now be on the MSP and not the user anymore.
It also fixes the "Successfully..." logging showing even though the user failed to send the file. This led to confusion.