feat: 📈 finish benchmarking the storage-providers pallet's extrinsics
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDemeco
changed the title
storage-providers palletstorage-providers pallet's extrinsics
2 tasks
snowmead
reviewed
Jan 31, 2025
pallets/providers/src/utils.rs
Outdated
| MainStorageProviders::<T>::remove(&provider_id); | ||
| AccountIdToMainStorageProviderId::<T>::remove(msp.owner_account); | ||
| // TODO: The buckets of this MSP should be moved to another one somehow, we can't leave the user without its data because |
There was a problem hiding this comment.
We could emit an event with all buckets that were being stored by the deleted MSP so users can recover them with move bucket requests.
There was a problem hiding this comment.
Good call, I added that!
snowmead
approved these changes
Jan 31, 2025
runtime/src/configs/mod.rs
Outdated
| @@ -498,6 +498,7 @@ impl pallet_storage_providers::Config for Runtime { | |||
| type StorageDataUnit = StorageDataUnit; | |||
| type StorageDataUnitAndBalanceConvert = StorageDataUnitAndBalanceConverter; | |||
| type SpCount = u32; | |||
| type BucketCount = u32; | |||
There was a problem hiding this comment.
Can we set this to be u128 to avoid any chances of overflowing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR benchmarks the two remaining unbenchmarked extrinsics from the
storage-providerspallet (top_up_depositanddelete_provider). To do so, it:MainStorageProvidertype that holds the metadata of a MSP:amount_of_value_props: the total amount of value propositions that this MSP has added to its repertoire. This is used to know how much weight is going to be needed to clean those value propositions from storage.amount_of_buckets: the current amount of buckets that the MSP is storing. This is also used to know how much weight is going to be needed to delete or move those buckets.BucketCount) to allow for flexibility when defining the maximum amount of buckets the user of the pallet deems a MSP can store.msp_sign_offextrinsic. Previously it was not clearing up the storage occupied by the MSP's value propositions, now it correctly clears everything.delete_providerextrinsic. Likemsp_sign_off, it was not clearing up the storage used by the value propositions if the provider to delete was a MSP, but this time becausedrain_prefixwas used but the iterator was never iterated so no elements were deleted.MainStorageProviderIdsToBucketsstorage, since with this extrinsic a MSP can be deleted while still having buckets. Like it was mentioned, specific logic to delete or move these buckets should be implemented in another PR.top_up_depositanddelete_provider.Fixes issue #24