fix: Skip BSP confirm file keys that have failed to update or create a payment stream #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santikaplan
approved these changes
Jan 24, 2025
Comment on lines
+1248
to
+1249
| // We ignore all errors from the payment stream operations (create/update) and add the file key to the skipped_file_keys set. | ||
| // This operation must be the first one to be executed before we being updating storage elements as to avoid any potential case |
There was a problem hiding this comment.
Suggested change
| // We ignore all errors from the payment stream operations (create/update) and add the file key to the skipped_file_keys set. | |
| // This operation must be the first one to be executed before we being updating storage elements as to avoid any potential case | |
| // All errors from the payment stream operations (create/update) are ignored, and the file key is added to the `skipped_file_keys` set. | |
| // This operation must be executed first, before updating any storage elements, to prevent potential cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the payment stream create and update block in
bsp_confirm_storingto skip file keys if those operations have failed.Moving these operations at the top avoids any possibility for any storage elements from being updated when they shouldn't if we skipped the file key.
See the audit issue raised for more details.
Fixes issue #30