Added errors to ClickX methods and added existence check #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziflex
added
type/bug
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
========================================
- Coverage 39.9% 39.9% -<.1%
========================================
Files 218 218
Lines 8619 8608 -11
========================================
- Hits 3441 3434 -7
+ Misses 4825 4821 -4
Partials 353 353 |
3timeslazy
reviewed
Jul 26, 2019
pkg/stdlib/html/pagination.go
Outdated
| exists, err := i.document.ExistsBySelector(ctx, i.selector) | ||
|
|
||
| if err != nil { | ||
| return values.ZeroInt, values.ZeroInt, err |
There was a problem hiding this comment.
Maybe return values.None instead values.ZeroInt?
There was a problem hiding this comment.
It does not really matter, since an execution gets terminated because of the returned error.
There was a problem hiding this comment.
To be consistent I'm suggest to return values.None every time error occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.7
CLICKandCLICK_ALLwas doing a check before clicking and was returning a boolean value indicating whether a target element was clicked.In 0.8 this logic got broken and the check is not performed.