Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIGHT() function should return substr counting from right rather than… #164

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

kiinoo
Copy link
Contributor

@kiinoo kiinoo commented Nov 6, 2018

RIGHT("abc",1) returns "bc".
but the expected result should be "c"?

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #164 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master    #164     +/-   ##
========================================
+ Coverage    57.5%   57.5%   +<.1%     
========================================
  Files         174     174             
  Lines        4932    4934      +2     
========================================
+ Hits         2834    2836      +2     
  Misses       1780    1780             
  Partials      318     318

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for your PR!
But could you add a unit test that verifies the fix?

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ziflex ziflex merged commit 528b60d into MontFerret:master Nov 7, 2018
@ziflex
Copy link
Member

ziflex commented Nov 7, 2018

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants