Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename utils.LOG -> utils.PRINT #162

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Conversation

3timeslazy
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #162 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #162     +/-   ##
========================================
- Coverage    57.5%   57.5%   -0.1%     
========================================
  Files         174     174             
  Lines        4932    4932             
========================================
- Hits         2838    2834      -4     
- Misses       1777    1780      +3     
- Partials      317     318      +1

"WAIT": Wait,
"LOG": Log,
"WAIT": Wait,
"PRINT": Log,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the function's name itself? :)

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the function's name.

@ziflex ziflex merged commit 8bb7941 into MontFerret:master Nov 6, 2018
@ziflex
Copy link
Member

ziflex commented Nov 6, 2018

Thank you for the PR!

@3timeslazy 3timeslazy deleted the feature/PRINT branch November 6, 2018 19:35
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* rename utils.LOG -> utils.PRINT

* rename utils.Logs -> utils.Print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants