Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DATE_DAYOFYEAR, DATE_MILLISECOND, DATE_LEAPYEAR, DATE_QUARTER, DATE_DAYS_IN_MONTH, DATE_FORMAT functions #157

Merged
merged 25 commits into from
Nov 5, 2018

Conversation

3timeslazy
Copy link
Member

No description provided.

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just fix the math :)

@3timeslazy 3timeslazy changed the title added DATE_DAYOFYEAR, DATE_MILLISECOND, DATE_LEAPYEAR functions added DATE_DAYOFYEAR, DATE_MILLISECOND, DATE_LEAPYEAR, DATE_QUARTER, DATE_DAYS_IN_MONTH, DATE_FORMAT functions Nov 4, 2018
@ziflex ziflex added type/enhancement New feature or request area/stdlib Standard library issue labels Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #157 into master will increase coverage by 0.12%.
The diff coverage is 71.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   56.84%   56.97%   +0.12%     
==========================================
  Files         166      174       +8     
  Lines        4774     4932     +158     
==========================================
+ Hits         2714     2810      +96     
- Misses       1738     1792      +54     
- Partials      322      330       +8
Impacted Files Coverage Δ
pkg/stdlib/datetime/lib.go 0% <0%> (ø) ⬆️
pkg/stdlib/datetime/format.go 100% <100%> (ø)
pkg/stdlib/datetime/millisecond.go 77.77% <77.77%> (ø)
pkg/stdlib/datetime/dayofyear.go 77.77% <77.77%> (ø)
pkg/stdlib/datetime/leapyear.go 81.81% <81.81%> (ø)
pkg/stdlib/datetime/daysinmonth.go 84.61% <84.61%> (ø)
pkg/stdlib/datetime/quarter.go 88.23% <88.23%> (ø)
pkg/html/dynamic/events/broker.go 58.62% <0%> (-1.38%) ⬇️
pkg/compiler/compiler.go 51.02% <0%> (ø) ⬆️
pkg/runtime/program.go 44.11% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd5af6...23676c9. Read the comment docs.

@ziflex ziflex merged commit e4a7b58 into MontFerret:master Nov 5, 2018
@ziflex
Copy link
Member

ziflex commented Nov 5, 2018

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/stdlib Standard library issue type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants