Feature/#10 merge recursive #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziflex
reviewed
Oct 24, 2018
| return merged.Clone(), nil | ||
| } | ||
|
|
||
| func merge(src, dst core.Value) core.Value { |
There was a problem hiding this comment.
If it's a private method and you use it for merging objects, why don't you define its arguments and the output as the*values.Object type?
There was a problem hiding this comment.
because this function can take values of different types at runtime
ziflex
requested changes
Oct 24, 2018
ziflex
reviewed
Oct 24, 2018
| merged := values.NewObject() | ||
|
|
||
| for _, arg := range args { | ||
| merged = merge(merged, arg.(*values.Object)).(*values.Object) |
There was a problem hiding this comment.
Ok, do we really need to cast arg to *values.Object if merge accepts core.Value?
ziflex
approved these changes
Oct 25, 2018
|
Great! Thank you for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.