Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GetFeaturePatches virtual so you don't need to override it #39

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Nytra
Copy link
Contributor

@Nytra Nytra commented Nov 2, 2024

99% of the time this is left empty anyway

@Nytra Nytra requested a review from Banane9 November 2, 2024 00:23
@Banane9
Copy link
Member

Banane9 commented Nov 2, 2024

Hmmm, maybe the whole feature thing needs to be reworked in general. It's a lot of definition work to set up and hard to make exhaustive.

Perhaps using the affected type (names) would work well enough. For anything using harmony patches that could be autogenerated anyways (analyzing the patch attributes or TargetMethod(s) method) , only for pre-patchers it could be trickier, though it could also be estimated based on the requested Assembly and Type definitions 🤔

@Nytra
Copy link
Contributor Author

Nytra commented Nov 2, 2024

It could do that, although there would still need to be a way to determine what feature a given type is a part of

@Banane9
Copy link
Member

Banane9 commented Nov 2, 2024

there would still need to be a way to determine what feature a given type is a part of

I guess we could use the namespace / type names for that. At least overall that should be fine 🤔

@Banane9 Banane9 merged commit 38debad into master Nov 22, 2024
@Banane9 Banane9 deleted the nytra/virtualGetFeaturePatches branch November 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants