Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an ItemChanged event to ConfigSections and fixes its FullId #33

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Adds an ItemChanged event to ConfigSections and fixes its FullId #33

merged 1 commit into from
Jul 31, 2024

Conversation

Banane9
Copy link
Member

@Banane9 Banane9 commented Jul 30, 2024

Implements #11

@Banane9 Banane9 added bug Something isn't working enhancement New feature or request labels Jul 30, 2024
@Banane9 Banane9 requested a review from Nytra July 30, 2024 22:32
@Banane9 Banane9 linked an issue Jul 30, 2024 that may be closed by this pull request
Add ItemChanged event to ConfigSection #11
Closed
@Banane9
Copy link
Member Author

Banane9 commented Jul 30, 2024

This will require some updates on any file based localizations to add ".Config" into them before config sections

Nytra
Nytra approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@Nytra Nytra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Banane9 Banane9 merged commit 8149586 into master Jul 31, 2024
@Banane9 Banane9 deleted the feature/add-configsection-itemchanged branch July 31, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nytra Nytra Nytra approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ItemChanged event to ConfigSection
2 participants
@Banane9 @Nytra