Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text auto from .sh files #32

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

ljoonal
Copy link
Member

@ljoonal ljoonal commented Jul 24, 2024

Please check that when you check out this that the .sh files (MonkeyLoader/vendor/run_monkeyloader.sh) have LF ending instead of CRLF 😄 .... as all files have LF ending for me anyways, can't really test to see that this works...

Fixes ResoniteModdingGroup/MonkeyLoader.GamePacks.Resonite#49

@ljoonal ljoonal added the bug Something isn't working label Jul 24, 2024
@ljoonal ljoonal requested a review from Banane9 July 24, 2024 17:00
@ljoonal
Copy link
Member Author

ljoonal commented Jul 24, 2024

Also it still annoys me to no end that GH treats this repo as a fork and recommends merging to @Banane9's personal original repo instead.... Could we not do something about that? :'D

@Banane9
Copy link
Member

Banane9 commented Jul 24, 2024

Yea, that's been annoying me too... We could merge all this back into the original and then transfer that 🤔

@ljoonal
Copy link
Member Author

ljoonal commented Jul 24, 2024

We could merge all this back into the original and then transfer that

Would that work? Wouldn't that mean deleting this repo, and losing all the starts/PR history/etc? Feel like re-creating the original would probably also solve the issue in a cleaner manner...? But then dunno, GH is dumb and to me best method from discussion threads would seem to be to contact GH support to fix their mess...

@Banane9
Copy link
Member

Banane9 commented Jul 24, 2024

Yea, true, that would fuck with the PRs n such.

I can just yeet the old repo and then it should be fine anyways

@Banane9 Banane9 merged commit 6b655f6 into master Jul 26, 2024
@Banane9 Banane9 deleted the fix/autocrlf-gitattributes-fix branch July 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong line endings in linux script file
2 participants