Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port various UX improvements from tg #4835

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Jan 12, 2025

About The Pull Request

Ports the following PRs from tg:

Why It's Good For The Game

Changelog

🆑
fix: (TiviPlus) Fixed clients being seen as stuck doing tutorials in some cases when changing mobs.
qol: (Melbert) When you are offered something, you can shift-click the alert to examine the item rather than take it.
qol: (Melbert) Examine blocks for screen alert examining.
qol: (Melbert) Screentips for offer alerts.
fix: (grungussuss) It is now possible to succumb without speaking.
qol: (tontyGH) You can now right-click the succumb action button to succumb silently.
qol: (tontyGH) The succumb inputs have a few more titles to choose from now.
fix: (tontyGH) The succumb text input now shows the actual correct number of characters you can say.
fix: (tontyGH) Attempting to cancel a succumb will no longer kill you.
spellcheck: (tontyGH) The text for failing to succumb is now spanned.
fix: (harryob) Ghosts observing ghosts can no longer click on their screen alerts.
qol: (mc-oofert) Alerts that do stuff when clicked glow gold.
qol: (Melbert) Hovering over clickable screen elements will now update your mouse cursor to indicate they're clickable.
qol: (Melbert) Hovering over small wall mounts (light switches, buttons, fire alarms) will now update to mouse cursor indicating you're hovering them.
/:cl:

TiviPlus and others added 14 commits January 11, 2025 23:25
## About The Pull Request

Dismisses the tutorial when the button is pushed

## Why It's Good For The Game

Some tutorials may pop up at inopportune moments and this lets players
deal with that, as well as when they bug out
## Changelog
:cl:
qol: Added a "Remind me later" button for tutorials
/:cl:

---------

Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
## About The Pull Request
client deletion isn't the only way to leave a mob
## Changelog
:cl:
fix: fixed clients being seen as stuck doing tutorials in some cases
when changing mobs
/:cl:

Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
## About The Pull Request
closes tgstation/tgstation#87479
## Changelog
:cl: grungussuss
fix: it is now possible to succumb without speaking
/:cl:
## About The Pull Request

fixes #87662 
Right-clicking the succumb alert will let you succumb without a message
also fixes a few bugs

## Fucked Up Looking Dog

![fucked-up-looking-dog-spookston](https://github.com/user-attachments/assets/9715ecfe-977f-41e1-b45b-050a111c6b54)

## Changelog

:cl:
qol: you can now right-click the succumb action button to succumb
silently
qol: the succumb inputs have a few more titles to choose from now
fix: the succumb text input now shows the actual correct number of
characters you can say
fix: attempting to cancel a succumb will no longer kill you
spellcheck: the text for failing to succumb is now spanned
/:cl:
## About The Pull Request

- When you are offered an item, you can shift-click the alert to examine
the item in the person's hands.
- Plus screen tips for offers. 
- Plus examine boxing alert examine text.


![image](https://github.com/tgstation/tgstation/assets/51863163/1b67b13e-46c2-44d0-a11d-427b1fc67bfb)

## Why It's Good For The Game

Simple thing. I figure people can get use out of it by, say, presenting
their ID for inspection, holding a paper out for someone to read,
checking how much ammo is in a gun someone hands you, etc etc.

## Changelog

:cl: Melbert
qol: When you are offered something, you can shift-click the alert to
examine the item rather than take it.
qol: Examine blocks for screen alert examining. 
qol: Screentips for offer alerts.  
/:cl:
closes #87572

usr does not necessarily mean owner for screen alerts, thanks Observe

shouldn't be teleporting other ghosts around
## About The Pull Request

Changes `examiante` to `examine` in the give alert description.
## Why It's Good For The Game

`examiante` ain't a word and, uh, `examinate` I don't think actually
fits here either.
## Changelog
:cl:
spellcheck: Give alert 'examiante' > 'examine'.
/:cl:
…ou how to get it off without water in the description (#87902)

 clickable alerts glow (regex: /atom/movable/screen/alert/.*/Click)

people are much more likely to look at the chat or anywhere else than
the status effect (really, its usually never worth reading 99% of them
so they end up ignored)

:cl:
qol: alerts that do stuff when clicked glow gold
/:cl:

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
… to indicate they are clickable (windows style) (#88470)

Basically just goes through and adds `mouse_over_pointer =
MOUSE_HAND_POINTER` to a bunch of screen elements (player hud and lobby
menu)

Also adds it to very small wall mounted objects like buttons, fire
alarms, and light switches

https://github.com/user-attachments/assets/c501cd3d-8efd-4fd0-a486-a53f2102a2cb

https://github.com/user-attachments/assets/89f7cdcb-b40c-4ef3-b578-fee66ddf1ce2

- Makes interacting with screen elements a bit more tactile
- Makes it a bit easier to click on tiny buttons and such (being able to
know when you're actually hovering the thing)
- Maybe can be expanded to more world objects to indicate they are
clickable vs non-interactable?

:cl: Melbert
qol: Hovering over clickable screen elements will now update your mouse
cursor to indicate they're clickable
qol: Hovering over small wall mounts (light switches, buttons, fire
alarms) will now update to mouse cursor indicating you're hovering them
/:cl:
@Absolucy Absolucy added Fix fix da bug QoL improves quality of life labels Jan 12, 2025
@flleeppyy
Copy link
Collaborator

YAYYYYYY MMORE FIXESS!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix da bug QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants