[PORT] sorting code improvements+optimizations #4797
+116
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
fuck it we ball
Absolucy
force-pushed
the
i-can-be-trusted-near-decade-old-code
branch
from
a1f6360 to
9177791
Compare
## About The Pull Request Datum var reads are expensive, and sorting code does a lot of them. let's work on that together, as a group. There's maybe 250ms of sorting cost sitting in mostly global variable work. I'd like to start chopping at that. My tracy profiles aren't the most helpful, estimating this to save about 14% of timSort over the course of init, tho that's slightly noisy and not the most reliable ## Why It's Good For The Game speed
1. Removes code duplication 2. Fully documents `sortTim()` 3. Makes a define with default sortTim behavior, straight and to the point for 95% of cases 4. Migrates other sorts into the same file 5. Removes some redundancy where they're reassigning a variable using an in place sorter For the record, we only use timSort More documentation, easier to read, uses `length` over `len`, etc Should be no gameplay effect at all
Absolucy
force-pushed
the
i-can-be-trusted-near-decade-old-code
branch
from
d404893 to
6f26e1f
Compare
Absolucy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ports the following PRs from tg:
there are likely far more that could be done, but I am not knowledgeable on sorting algorithms
Changelog
no user-facing changes