Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test and fix for delete with write_concern w:0 #1037

Merged

Conversation

MRigal
Copy link
Member

@MRigal MRigal commented Jun 21, 2015

Fix #1008

Review on Reviewable

@MRigal MRigal added the Bug label Jun 21, 2015
@MRigal MRigal added this to the 0.10 milestone Jun 21, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling bcc4d4e on MRigal:fix/1008-delete-returns-none-allowed into 5fa5284 on MongoEngine:master.

@thedrow
Copy link
Contributor

thedrow commented Jun 21, 2015

Why the test doesn't have any assert?

@MRigal
Copy link
Member Author

MRigal commented Jun 21, 2015

@thedrow I made it quickly and the tests where failing before my fix. But you're right, it is better explicit, like this

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling d0b749a on MRigal:fix/1008-delete-returns-none-allowed into 5fa5284 on MongoEngine:master.

MRigal added a commit that referenced this pull request Jun 22, 2015
…owed

Added test and fix for delete with write_concern w:0
@MRigal MRigal merged commit ef5fa4d into MongoEngine:master Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants