Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1

Merged
merged 6 commits into from
Jun 5, 2019
Merged

Update dependencies #1

merged 6 commits into from
Jun 5, 2019

Conversation

louich
Copy link
Contributor

@louich louich commented Jun 4, 2019

Out dated revision github.com/Mongey/ksql@7f949ab529b9871d39185c6705f543a21fe25eba

When installing package with go modules, go install throws:

go: converting Gopkg.lock: stat github.com/Mongey/ksql@7f949ab529b9871d39185c6705f543a21fe25eba: unknown revision 7f949ab529b9871d39185c6705f543a21fe25eba

@Mongey
Copy link
Owner

Mongey commented Jun 5, 2019

Thanks @louich ! Sorry that you ran into issues. I pushed some extra commits to fixup CI + fully move over to go modules. Hopefully that works 🙏

@louich
Copy link
Contributor Author

louich commented Jun 5, 2019

Yeah 👌 excellent job. Thanks for your responsiveness, it seems to build fine. Will you merge it soon?

@Mongey Mongey merged commit c29ce52 into Mongey:master Jun 5, 2019
@louich louich deleted the fix-go-install branch June 5, 2019 15:38
@louich
Copy link
Contributor Author

louich commented Jun 5, 2019

Many thanks 🎉

@Mongey
Copy link
Owner

Mongey commented Jun 5, 2019

np! :shipit: :shipit: :shipit: :shipit:

Hopefully it works 😅 It's been quite a while since I've used KSQL / this provider. Raise some issues if you run into anything and I can take a look 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants