Fix udf debugging and remove an annoying tox warning #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3, pickles are bytes objects, not strings. There seems to be a problem with py3embed and blobs, so for the time being we use hex encoded strings.
Replace past.builtins.execfile with compile + exec
gijzelaerr
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #49. The problem was that as of Python3, pickle no longer returns strings but bytes objects. First I attempted to let the
export_parametersfunction return a BLOB but that didn't work so in the mean time it returns a hex encoding of the bytes.With this issue fixed I could test my fix for the deprecation warning that shows up in the tox output: